Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jmks deprecate camel case attributes #470

Merged
merged 10 commits into from Aug 15, 2023
Merged

Jmks deprecate camel case attributes #470

merged 10 commits into from Aug 15, 2023

Commits on Aug 15, 2023

  1. Add utils function to warn on non-snake case attributes

    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    836f03b View commit details
    Browse the repository at this point in the history

  2. Check attributes when searching an index

    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5f18963 View commit details
    Browse the repository at this point in the history

  3. Rename MeiliSearch to Meilisearch in the deprecation warning message

    @brunoocasali
    brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    8db19a1 View commit details
    Browse the repository at this point in the history

  4. Apply attribute warning everywhere

    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9203f2c View commit details
    Browse the repository at this point in the history

  5. Update specs to use snake_case attributes

    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    b59b1dc View commit details
    Browse the repository at this point in the history

  6. Drop specs for snake case attributes 

    All the specs use snake case attributes now and dropping these did
not affect test coverage.
    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    3658843 View commit details
    Browse the repository at this point in the history

  7. Update docs to use snake_case

    @jmks @brunoocasali
    jmks authored and brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    537bf61 View commit details
    Browse the repository at this point in the history

  8. Fix conflicts and update code to work in v1.3

    @brunoocasali
    brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fb6354e View commit details
    Browse the repository at this point in the history

  9. Fix/Ignore rubocop 🙈

    @brunoocasali
    brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9330366 View commit details
    Browse the repository at this point in the history

  10. Rollback meilisearch v1.3 from docker-compose

    @brunoocasali
    brunoocasali committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9147580 View commit details
    Browse the repository at this point in the history