Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define fields to search on at search-time #479

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Define fields to search on at search-time #479

merged 4 commits into from
Sep 1, 2023

Conversation

davidpan
Copy link
Contributor

@davidpan davidpan commented Aug 22, 2023 •
edited
Loading

Pull Request

Related issue

Fixes #458

What does this PR do?

  • Add the ability to receive a new param in the search method called attributesToSearchOn.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@davidpan @andre-m-dev
Update lib/meilisearch/index.rb
2f15d04 
Co-authored-by: André <1729839+andre-m-dev@users.noreply.github.com>
brunoocasali
brunoocasali approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 1, 2023

Build succeeded:

@davidpan davidpan closed this Sep 1, 2023
@meili-bors meili-bors bot merged commit 7be1ef4 into meilisearch:main Sep 1, 2023
1 check passed
@curquiza curquiza changed the title Add V1.3 Define fields to search on at search-time Define fields to search on at search-time Sep 13, 2023
@curquiza curquiza added the enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-m-dev andre-m-dev andre-m-dev left review comments

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.3] Define fields to search on at search-time (attributesToSearchOn)
4 participants
@davidpan @andre-m-dev @brunoocasali @curquiza