Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement facet_search #496

Merged
merged 5 commits into from Oct 16, 2023
Merged

Implement facet_search #496

merged 5 commits into from Oct 16, 2023

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Oct 6, 2023

Pull Request

Related issue

Fixes #462

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@ellnix ellnix changed the title Facet search Implement facet_search Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fb6bbc0) 99.62% compared to head (16a257a) 99.62%.

❗ Current head 16a257a differs from pull request most recent head 5e31f7c. Consider uploading reports for the commit 5e31f7c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files           9        9           
  Lines         530      534    +4     
=======================================
+ Hits          528      532    +4     
  Misses          2        2           
Files Coverage Δ
lib/meilisearch/index.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ellnix
Copy link
Collaborator Author

ellnix commented Oct 9, 2023

@brunoocasali

Again the problem is that class Index is too long, but I cannot fix that without touching code that does not belong in this PR.

@ellnix
Copy link
Collaborator Author

ellnix commented Oct 11, 2023

Rebased, with linter fixed again. 🚀 😄

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ellnix 🎉

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 16, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit d2ffa58 into meilisearch:main Oct 16, 2023
6 checks passed
@brunoocasali brunoocasali added the enhancement New feature or request label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Search in facet values facetSearch
2 participants