-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version targets (Ruby 3.1, Ubuntu 22.04) #510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 9 9
Lines 534 534
=======================================
Hits 532 532
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ellnix
can you update the bors.toml file please?
536f3f3
to
2537313
Compare
Should be good now. Sorry didn't know about Edit: codecov failed on the ruby 2.7 test, but everything should be fine |
Don't worry, I'm here to remind 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors merge
bors merge |
🔒 Permission denied Existing reviewers: click here to make ellnix a reviewer |
bors merge |
@ellnix I just gave you access to merge, sorry for the trouble |
bors try |
bors merge |
I was thinking the same thing, so I triggered the failing test to re-run. Edit: Everything is passing now. |
LGTM, you can merge @ellnix |
tryMerge conflict. |
Pull Request
Related issue
Fixes #507
Apologies for not doing this immediately, but I didn't do any programming during the holidays.