Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version targets (Ruby 3.1, Ubuntu 22.04) #510

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Jan 10, 2024

Pull Request

Related issue

Fixes #507

  • I didn't remove ruby 2.6 as it continues to be supported and I don't feel comfortable removing tests for a supported version of ruby, the test suite may be a bit bloated now though.

Apologies for not doing this immediately, but I didn't do any programming during the holidays.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d8c1e3) 99.62% compared to head (2537313) 99.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files           9        9           
  Lines         534      534           
=======================================
  Hits          532      532           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ellnix

can you update the bors.toml file please?

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 11, 2024

Thanks @ellnix

can you update the bors.toml file please?

Should be good now. Sorry didn't know about bors.toml.

Edit: codecov failed on the ruby 2.7 test, but everything should be fine

@curquiza
Copy link
Member

Should be good now. Sorry didn't know about bors.toml.

Don't worry, I'm here to remind 😊

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 11, 2024
@ellnix
Copy link
Collaborator Author

ellnix commented Jan 12, 2024

bors merge

Copy link
Contributor

meili-bors bot commented Jan 12, 2024

🔒 Permission denied

Existing reviewers: click here to make ellnix a reviewer

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

@ellnix I just gave you access to merge, sorry for the trouble

@curquiza
Copy link
Member

bors try

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 15, 2024

bors merge

@curquiza
Copy link
Member

Looks like bors has an issue, sometimes we have issue like this:

Capture d’écran 2024-01-15 à 11 19 53

What I do in this case is merging manually
But I want to ensure the tests all pass, which is not the case currently

@ellnix
Copy link
Collaborator Author

ellnix commented Jan 15, 2024

What I do in this case is merging manually But I want to ensure the tests all pass, which is not the case currently

I was thinking the same thing, so I triggered the failing test to re-run.

Edit: Everything is passing now.

@curquiza
Copy link
Member

LGTM, you can merge @ellnix

@ellnix ellnix merged commit ed4dc30 into meilisearch:main Jan 15, 2024
8 of 9 checks passed
Copy link
Contributor

meili-bors bot commented Jan 16, 2024

try

Merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all github actions to reflect new version targets
2 participants