Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error propagating logic #515

Merged
merged 3 commits into from Jan 29, 2024
Merged

Fix error propagating logic #515

merged 3 commits into from Jan 29, 2024

Commits on Jan 17, 2024

  1. Test version_error_handler with realistic data 

    Meilisearch::ApiError parses a server's JSON response into its
`@http_body` instance variable which stores a hash.
When `version_error_handler` propagates ApiError, it passes `@http_body`
as the server http body which causes ApiError to attempt to parse it
again as JSON, throwing a TypeError.
    @ellnix
    ellnix committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6e091ad View commit details
    Browse the repository at this point in the history

  2. Update ApiError to accept a hash as http_body 

    Allows easier propagation of ApiError.
    @ellnix
    ellnix committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5c40b93 View commit details
    Browse the repository at this point in the history

  3. Add spec for ApiError with html body

    @ellnix
    ellnix committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bbcfa7f View commit details
    Browse the repository at this point in the history