Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ruby 2 and add ruby 3.2 to CI #516

Merged
merged 1 commit into from Feb 2, 2024

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Jan 17, 2024

Pull Request

Related issue

Fixes #514

What does this PR do?

  • Drops support for ruby 2.6 and 2.7

I thought I would have the PR ready for whenever we decide to pull the trigger on this. This is not to say that I think we should drop support for these ruby versions right away.

@ellnix ellnix added breaking-change The related changes are breaking for the users maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40f80cb) 99.62% compared to head (1d2462d) 99.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files           9        9              
  Lines         540      538       -2     
==========================================
- Hits          538      536       -2     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me & @brunoocasali

bors merge

@brunoocasali brunoocasali merged commit fd0a989 into meilisearch:main Feb 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase required ruby version
3 participants