Implement the get_or_create_index method

[curquiza]

No description provided.

[eskombro]

I would add a test calling more than once get_or_create_index, checking that it doesn't create a new one but also doesn't raise an error. Otherwise, it seems perfect!

[curquiza]

@eskombro

I would add a test calling more than once get_or_create_index, checking that it doesn't create a new one but also doesn't raise an error

There's already a test named get an already existing index with get_or_create_index method checking:

• the UID
• that the indexes count did not increase
• there is no error raised (otherwise, the tests suite would stop)

Remember, the tests are not independent between them, there are only dependent on the context. The test I mention follows a previous call of get_or_created_index, so I already call more than once get_or_created_index in the same context.

[eskombro]

@eskombro

I would add a test calling more than once get_or_create_index, checking that it doesn't create a new one but also doesn't raise an error

There's already a test named get an already existing index with get_or_create_index method checking:

* the UID

* that the indexes count did not increase

* there is no error raised (otherwise, the tests suite would stop)

Remember, the tests are not independent between them, there are only dependent on the context. The test I mention follows a previous call of get_or_created_index, so I already call more than once get_or_created_index in the same context.

You are right, I was reviewing each test as a single entity, didn't think that this was indeed tested anyways. I would still add it to make it an explicit test, because they can evolve and we won't necessarily think of this while modifying it, but it is indeed tested and not really urgent!

[curquiza]

Since all of our tests are not independent, it is not really useful to make this test specifically dependent and not the others (like gets list of indexes or shows a specific index...).
But we should indeed think about a re-do of our tests suite to make our tests independent, as a contributor did for the PHP package.