Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sysinfo routes #75

Merged
merged 2 commits into from Jul 21, 2020
Merged

Remove sysinfo routes #75

merged 2 commits into from Jul 21, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jul 20, 2020 •
edited

Closes #75

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Jul 20, 2020
@curquiza curquiza requested a review from eskombro July 20, 2020 17:53
@curquiza curquiza mentioned this pull request Jul 21, 2020
Merged
eskombro
eskombro previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Maybe we can remove the examples from the code samples (even if they are empty)

@curquiza curquiza merged commit a2d6632 into bump-meilisearch-v0.13.0 Jul 21, 2020
@curquiza curquiza deleted the remove-sys-info branch July 21, 2020 15:54
@eskombro eskombro mentioned this pull request Jul 27, 2020
Closed
@eskombro eskombro linked an issue Jul 27, 2020 that may be closed by this pull request
Remove sys-info routes #72
Closed
curquiza added a commit that referenced this pull request Aug 3, 2020
@curquiza
Bump MeiliSearch to v0.13.0 (#74)
add6a7e 
* Update README.md

* Remove sysinfo routes (#75)

* Remove sysinfo routes

* Remove sys info in code samples

* Update settings following the settings behavior changes on MeiliSearch (#78)

* Update settings following the settings behavior changes on MeiliSearch
* Remove acceptNewFields examples in code samples

* Use POST instead of GET in search method (#77)

Add tests for placeholder
eskombro added a commit that referenced this pull request Sep 1, 2020
@eskombro @curquiza
MeiliSearch Bump to v0.13.0 (#83)
ecb7ed1 
* Update README.md
* Remove sysinfo routes (#75)
* Update settings following the settings behavior changes on MeiliSearch (#78)
* Remove acceptNewFields
* Use POST instead of GET in search method (#77)

Add tests for placeholder

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bidoubiwa pushed a commit that referenced this pull request Mar 8, 2021
@curquiza @bidoubiwa
Bump MeiliSearch to v0.13.0 (#74)
8f9f098 
* Update README.md

* Remove sysinfo routes (#75)

* Remove sysinfo routes

* Remove sys info in code samples

* Update settings following the settings behavior changes on MeiliSearch (#78)

* Update settings following the settings behavior changes on MeiliSearch
* Remove acceptNewFields examples in code samples

* Use POST instead of GET in search method (#77)

Add tests for placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro left review comments

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sys-info routes
2 participants
@curquiza @eskombro