Improve Query and SearchResults #46

Mubelotix · 2020-08-21T14:58:54Z

Will close #41

TODO

Query

Add the matches option
Change attributes_to_crop into an array
Change attributes_to_highlight into an array
Change attributes_to_retrieve into an array
Change method of the search route from GET to POST
Make the query string optional

Results

Support matches_info
Support formatted results

Mubelotix · 2020-08-22T07:56:35Z

It will also close #45

curquiza

Thanks for these changes!

Some questions:

are there any tests for the search method but with optional parameters (attributesToCrop, facetsDistribution...)? If not, can you add some of them? 🙂
Do your changes involve modification in this PR Add code-sample file #40?

I put the breaking-changes flag since your changes seem to be breaking! (this flag will automatically increase the minor number of the version instead of the patch one)

src/search.rs

Kerollmops · 2020-08-23T13:30:14Z

src/search.rs

+    /// The object that contains information about the matches.
+    #[serde(rename = "_matchesInfo")]
+    pub matches_info: Option<HashMap<String, Vec<MatchRange>>>
+}

 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
 /// A struct containing search results and other information about the search.
 pub struct SearchResults<T> {


Maybe we could make it a serde_json::Value when the user don't specify it?
On the SearchResults or SearchResult structs, I don't know, what do you think about that?

struct SearchResults<T: Value> {

I am not sure if it would be useful in some cases. But is this possible without making a new method ? If yes we could do it anyway

I'm not sure I understand, why would it need a new method? The T type must implement Ser/Deserialize so it works with serde_json::Value if the user doesn't specify the T type itself.

Ask me any question, I am not sure my message above helps much, and also, this is not mandatory to implement.

src/search.rs

Mubelotix · 2020-08-24T06:14:55Z

Yes it's a breaking change so there will be some things to change in the sample file @curquiza

Mubelotix · 2020-09-06T17:00:40Z

@curquiza I think it would be better to write new tests when we improve the existing ones (see #29). There will be major changes soon.

curquiza · 2020-09-09T15:50:33Z

Okay, @Mubelotix, but it should be done soon in case there is an error. For the momebt, I have no proof it works without any test.

curquiza · 2020-09-09T15:51:30Z

Have all the changes asked @Kerollmops been taken into account? Is this PR ready for merging?

Change Vecs to &[]

see #47

Mubelotix · 2020-10-03T08:49:51Z

Let's merge fast so we can merge #40 too.

Kerollmops

This is great work 😄 But maybe you could chnage the builder a little bit!

README.md

src/search.rs

Co-authored-by: Kerollmops <clement@meilisearch.com>

curquiza · 2020-10-12T08:28:02Z

bors try

bors · 2020-10-12T08:34:50Z

try

Build failed:

Rust tests

curquiza · 2020-10-12T08:55:30Z

@Mubelotix, the tests fail when you make your branch up to date with master. It will be impossible to merge even if Kero approves your PR.
Maybe you should rebase your branch to check what's wrong 🙂

Kerollmops

Thank you very much for these changes, I started to complain about the build, execute and execute_query but it is not that bad in fact.

I think the Index::execute_query is here just to be able to use the same query on multiple indexes 👍

curquiza · 2020-10-19T08:27:28Z

bors try

bors · 2020-10-19T08:33:45Z

try

Build succeeded:

Rust tests

curquiza

🚀

curquiza · 2020-10-19T08:56:33Z

bors merge

bors · 2020-10-19T09:02:26Z

Build succeeded:

Rust tests

Mubelotix linked an issue Aug 22, 2020 that may be closed by this pull request

Change search route method #45

Closed

Mubelotix marked this pull request as ready for review August 22, 2020 08:31

curquiza requested changes Aug 22, 2020

View reviewed changes

src/search.rs Outdated Show resolved Hide resolved

src/search.rs Outdated Show resolved Hide resolved

curquiza added the breaking-change The related changes are breaking for the users label Aug 22, 2020

curquiza requested a review from Kerollmops August 22, 2020 16:23

Kerollmops requested changes Aug 23, 2020

View reviewed changes

Mubelotix mentioned this pull request Sep 24, 2020

Empty query returns no results #47

Closed

Mubelotix linked an issue Sep 24, 2020 that may be closed by this pull request

Empty query returns no results #47

Closed

Mubelotix added 17 commits October 1, 2020 19:10

Add formatting support

2f3b191

Add matchesInfo support

d92d3a6

Improve attributes_to_crop

6b847f4

Improve attributes_to_highlight

5ea7b15

Remove useless indentation

5689d4a

Improve attributes_to_retrieve

72b0904

Improve other fields

4864a50

Change Vecs to &[]

Fix clippy warning

f5a8fcb

Add a test

5bab76b

Change search route method to POST

21d7fd1

Apply suggestions

223fad0

Implement a more idiomatic wildcard value

fecbb0c

Improve and update documentation

85d5032

Remove useless dependency

4254eac

Make the query string optional

433db17

see #47

Update readme

249f2f6

Add 11 tests

69f90c6

Mubelotix force-pushed the search-improvements branch from 213c2b9 to 69f90c6 Compare October 1, 2020 17:10

Mubelotix added 3 commits October 1, 2020 19:28

Fix clippy warning

7fdbd2f

Add new line at the end of the file

61e9a0a

Fix typo

faa312e

Mubelotix requested review from Kerollmops and curquiza October 3, 2020 08:16

curquiza added the Hacktoberfest label Oct 5, 2020

curquiza mentioned this pull request Oct 5, 2020

Settings improvements #51

Closed

Kerollmops requested changes Oct 5, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

src/search.rs Outdated Show resolved Hide resolved

src/search.rs Outdated Show resolved Hide resolved

src/search.rs Outdated Show resolved Hide resolved

src/search.rs Outdated Show resolved Hide resolved

Mubelotix mentioned this pull request Oct 7, 2020

Testing against populated data #53

Closed

Mubelotix and others added 4 commits October 11, 2020 10:27

Apply suggestions

6a9983f

Co-authored-by: Kerollmops <clement@meilisearch.com>

Cargo fmt

ba12d40

Update readme

a5afb2a

Fix warning

80e210a

curquiza requested a review from Kerollmops October 12, 2020 08:27

bors bot added a commit that referenced this pull request Oct 12, 2020

Try #46:

946c1df

Fix tests

d400b17

Kerollmops approved these changes Oct 15, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Oct 19, 2020

Try #46:

580924c

curquiza approved these changes Oct 19, 2020

View reviewed changes

bors bot merged commit 6e89e9e into master Oct 19, 2020

bors bot deleted the search-improvements branch October 19, 2020 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Query and SearchResults #46

Improve Query and SearchResults #46

Mubelotix commented Aug 21, 2020 •

edited

Mubelotix commented Aug 22, 2020

curquiza left a comment

Kerollmops Aug 23, 2020

Mubelotix Aug 24, 2020

Kerollmops Aug 24, 2020

Mubelotix commented Aug 24, 2020

Mubelotix commented Sep 6, 2020

curquiza commented Sep 9, 2020

curquiza commented Sep 9, 2020

Mubelotix commented Oct 3, 2020

Kerollmops left a comment

curquiza commented Oct 12, 2020

bors bot commented Oct 12, 2020

curquiza commented Oct 12, 2020 •

edited

Kerollmops left a comment

curquiza commented Oct 19, 2020

bors bot commented Oct 19, 2020

curquiza left a comment

curquiza commented Oct 19, 2020

bors bot commented Oct 19, 2020

Improve Query and SearchResults #46

Improve Query and SearchResults #46

Conversation

Mubelotix commented Aug 21, 2020 • edited

TODO

Query

Results

Mubelotix commented Aug 22, 2020

curquiza left a comment

Choose a reason for hiding this comment

Kerollmops Aug 23, 2020

Choose a reason for hiding this comment

Mubelotix Aug 24, 2020

Choose a reason for hiding this comment

Kerollmops Aug 24, 2020

Choose a reason for hiding this comment

Mubelotix commented Aug 24, 2020

Mubelotix commented Sep 6, 2020

curquiza commented Sep 9, 2020

curquiza commented Sep 9, 2020

Mubelotix commented Oct 3, 2020

Kerollmops left a comment

Choose a reason for hiding this comment

curquiza commented Oct 12, 2020

bors bot commented Oct 12, 2020

try

curquiza commented Oct 12, 2020 • edited

Kerollmops left a comment

Choose a reason for hiding this comment

curquiza commented Oct 19, 2020

bors bot commented Oct 19, 2020

try

curquiza left a comment

Choose a reason for hiding this comment

curquiza commented Oct 19, 2020

bors bot commented Oct 19, 2020

Mubelotix commented Aug 21, 2020 •

edited

curquiza commented Oct 12, 2020 •

edited