Fixed issue where the default revision is always the one we picked fo…

…r the default model
meilisearch · Dec 20, 2023 · 333ce12 · 333ce12
1 parent fb9db1e
commit 333ce12
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/milli/src/vector/settings.rs b/milli/src/vector/settings.rs
@@ -228,6 +228,12 @@ impl From<HfEmbedderSettings> for crate::vector::hf::EmbedderOptions {
         let mut this = Self::default();
         if let Some(model) = model.set() {
             this.model = model;
+            // Reset the revision if we are setting the model.
+            // This allows the following:
+            // "huggingFace": {} -> default model with default revision
+            // "huggingFace": { "model": "name-of-the-default-model" } -> default model without a revision
+            // "huggingFace": { "model": "some-other-model" } -> most importantly, other model without a revision
+            this.revision = None;
         }
         if let Some(revision) = revision.set() {
             this.revision = Some(revision);