Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker CI: should not display unknown as commit SHA and commit date #2028

Closed
curquiza opened this issue Dec 20, 2021 · 3 comments · Fixed by #3212
Closed

Docker CI: should not display unknown as commit SHA and commit date #2028

curquiza opened this issue Dec 20, 2021 · 3 comments · Fixed by #3212
Labels
bug Something isn't working as expected good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone

Comments

@curquiza
Copy link
Member

Since v0.25.0 and the introduction of the new CI, MeiliSearch running on Docker does not display the commit sha and the commit date:

Capture d’écran 2021-12-20 à 17 28 37

When building locally, I don't have any commit sha and date issue, they are well displayed at MeiliSearch launch.

@curquiza curquiza added bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) contribution accepted This issue accepts external contributions labels Dec 20, 2021
@MarinPostma
Copy link
Contributor

@curquiza, after giving it a quick glance, it seems that this PR removes the use of env variables for building the image, in favor of importing the .git directory. But it seems that we you are still expecting to find these variables in the dockerfile here, and I see nowhere where the .git is actually copied. Not sure how all of that workds, but it may be worth to take a look at that.

@curquiza curquiza added the good first issue Good for newcomers label May 4, 2022
brunoocasali added a commit to brunoocasali/meilisearch that referenced this issue Jun 24, 2022
@curquiza curquiza added this to the v0.29.0 milestone Jul 6, 2022
brunoocasali added a commit to brunoocasali/meilisearch that referenced this issue Jul 11, 2022
@curquiza curquiza modified the milestones: v0.29.0, v0.30.0 Aug 22, 2022
@curquiza curquiza removed the contribution accepted This issue accepts external contributions label Sep 12, 2022
@curquiza curquiza modified the milestones: v0.30.0, v1.0.0 Oct 17, 2022
@amab8901
Copy link
Contributor

amab8901 commented Nov 30, 2022

I'm unable to reproduce the error for the latest version of meilisearch on dockerhub.

$ sudo docker run --rm -e MEILI_NO_ANALYTICS=true -p 770:770 getmeili/meilisearch:v0.30.0 ./meilisearch --master-
key=masterKey
Unable to find image 'getmeili/meilisearch:v0.30.0' locally
v0.30.0: Pulling from getmeili/meilisearch
ca7dd9ec2225: Pull complete 
3628dd4a8988: Pull complete 
e5d3cc55b1bb: Pull complete 
b0545ee3798f: Pull complete 
d9faa5b12225: Pull complete 
Digest: sha256:364782ac9f870eefb18259b6c0f4652dcb7c8d375233b6e358a51047a9fc4272
Status: Downloaded newer image for getmeili/meilisearch:v0.30.0
[FATAL tini (7)] exec ./meilisearch failed: No such file or directory

@curquiza
Copy link
Member Author

Hello @amab8901, yes we know the bug still exists, @brunoocasali is working on a fix in this PR #2550 😇
Thanks for letting us know

@bors bors bot closed this as completed in c426fa1 Dec 8, 2022
@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
No open projects
Status: Done
4 participants