Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoSearch: Support string type for _geo lat and lng fields #2354

Closed
curquiza opened this issue Apr 26, 2022 · 2 comments
Closed

GeoSearch: Support string type for _geo lat and lng fields #2354

curquiza opened this issue Apr 26, 2022 · 2 comments
Labels
enhancement New feature or improvement good first issue Good for newcomers impacts docs This issue involves changes in the Meilisearch's documentation milli Related to the milli workspace v0.28.0 PRs/issues solved in v0.28.0
Milestone
v0.28.0

Comments

@curquiza
Copy link
Member

Following this spec: meilisearch/specifications#83

When indexing the _geo field as a filterable or sortable attribute, MeiliSearch should be able to parse string or numeric values rather than raise an invalid_geo_field error.

Please, feel free to ask any question to be helped by the core team if needed
@curquiza curquiza added enhancement New feature or improvement good first issue Good for newcomers milli Related to the milli workspace labels Apr 26, 2022
@irevoire irevoire mentioned this issue May 2, 2022
Merged
bors bot added a commit to meilisearch/milli that referenced this issue May 4, 2022
@bors @irevoire
Merge #523
65e6aa0 
523: Improve geosearch error messages r=irevoire a=irevoire

Improve the geosearch error messages (#488).
And try to parse the string as specified in meilisearch/meilisearch#2354

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza curquiza added this to the v0.28.0 milestone May 4, 2022
@curquiza curquiza changed the title GeoSearch — Support string type for _geo lat and lng fields GeoSearch: Support string type for _geo lat and lng fields May 5, 2022
@curquiza
Copy link
Member Author

@meilisearch/docs-team, maybe it impacts your documentation

@curquiza curquiza added the impacts docs This issue involves changes in the Meilisearch's documentation label May 17, 2022
@irevoire
Copy link
Member

This has already been fixed by #2408

@guimachiavelli guimachiavelli mentioned this issue Jun 7, 2022
Closed
@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement good first issue Good for newcomers impacts docs This issue involves changes in the Meilisearch's documentation milli Related to the milli workspace v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
Development

No branches or pull requests
2 participants
@irevoire @curquiza