Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V0.28.0rc0 attributesToHighlight/attributesToCrop: * not working on GET /search route #2527

Closed
bidoubiwa opened this issue Jun 15, 2022 · 2 comments · Fixed by #2543
Closed

V0.28.0rc0 attributesToHighlight/attributesToCrop: * not working on GET /search route #2527

bidoubiwa opened this issue Jun 15, 2022 · 2 comments · Fixed by #2543
Assignees
@irevoire
Labels
bug Something isn't working as expected v0.28.0 PRs/issues solved in v0.28.0
Milestone
v0.28.0

Comments

@bidoubiwa
Copy link
Contributor

Describe the bug
When making a request on the GET /search routes adding attributesToHighlight: * does not create a _formatted object.
At the contrary, adding a specific field attributesToHighlight: title for example, works correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Make a search request using the GET method
  2. add attributesToHighlight: * as a query parameter
  3. _formatted is not created nor is there anything highlighted

Expected behavior
attributesToHighlight should be taken into account.

Screenshots
Screenshot 2022-06-15 at 18 31 45

Meilisearch version: [e.g. v0.20.0]
v0.28.0rc0
@bidoubiwa bidoubiwa changed the title V0.28.0rc0 attributesToHighlight: * not working on GET /search route V0.28.0rc0 attributesToHighlight/attributesToCrop: * not working on GET /search route Jun 15, 2022
@curquiza curquiza added the bug Something isn't working as expected label Jun 15, 2022
@curquiza curquiza added this to the v0.28.0 milestone Jun 15, 2022
@curquiza
Copy link
Member

Thanks @bidoubiwa

We need to add tests 🔥

@bidoubiwa bidoubiwa mentioned this issue Jun 16, 2022
Merged
7 tasks
@irevoire irevoire mentioned this issue Jun 22, 2022
Merged
bors bot added a commit that referenced this issue Jun 23, 2022
@bors @irevoire
Merge #2543
9e261b9 
2543: fix all the array on the search get route and improve the tests r=curquiza a=irevoire

fix #2527

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Closed by #2543

@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

fix all the array on the search get route and improve the tests meilisearch/meilisearch
3 participants
@irevoire @curquiza @bidoubiwa