Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename settings limitedTo into maxTotalHits #2542

Closed
curquiza opened this issue Jun 22, 2022 · 2 comments · Fixed by #2546
Closed

Rename settings limitedTo into maxTotalHits #2542

curquiza opened this issue Jun 22, 2022 · 2 comments · Fixed by #2546
Assignees
@Kerollmops
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations milli Related to the milli workspace v0.28.0 PRs/issues solved in v0.28.0
Milestone
v0.28.0

Comments

@curquiza
Copy link
Member

Following this change in the spec and this issue

We need to rename the new setting limitedTo into maxTotalHits
@curquiza curquiza added the enhancement New feature or improvement label Jun 22, 2022
@curquiza curquiza added this to the v0.28.0 milestone Jun 22, 2022
@curquiza curquiza added impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations labels Jun 22, 2022
@curquiza
Copy link
Member Author

@meilisearch/integration-team @meilisearch/docs-team

@Kerollmops Kerollmops self-assigned this Jun 22, 2022
@curquiza curquiza mentioned this issue Jun 22, 2022
Closed
3 tasks
@Kerollmops Kerollmops mentioned this issue Jun 22, 2022
Merged
bors bot added a commit to meilisearch/milli that referenced this issue Jun 22, 2022
@bors @Kerollmops
Merge #564
345f3cc 
564: Rename the limitedTo parameter into maxTotalHits r=irevoire a=Kerollmops

This PR is related to meilisearch/meilisearch#2542, it renames the `limitedTo` parameter into `maxTotalHits`.

Co-authored-by: Kerollmops <clement@meilisearch.com>
bors bot added a commit to meilisearch/milli that referenced this issue Jun 22, 2022
@bors @Kerollmops
Merge #564
290a40b 
564: Rename the limitedTo parameter into maxTotalHits r=curquiza a=Kerollmops

This PR is related to meilisearch/meilisearch#2542, it renames the `limitedTo` parameter into `maxTotalHits`.

Co-authored-by: Kerollmops <clement@meilisearch.com>
@curquiza curquiza added the milli Related to the milli workspace label Jun 22, 2022
@curquiza curquiza linked a pull request Jun 23, 2022 that will close this issue
Bump milli to 0.31.1 #2546
Merged
@curquiza
Copy link
Member Author

Closed by #2546

@curquiza curquiza mentioned this issue Jun 27, 2022
Closed
@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerollmops Kerollmops

Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations milli Related to the milli workspace v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

Bump milli to 0.31.1 meilisearch/meilisearch
2 participants
@Kerollmops @curquiza