Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error handling in the download-latest.sh script #3044

Closed
irevoire opened this issue Nov 14, 2022 · 0 comments · Fixed by #3169
Closed

Improve the error handling in the download-latest.sh script #3044

irevoire opened this issue Nov 14, 2022 · 0 comments · Fixed by #3169
Assignees
@curquiza
Labels
enhancement New feature or improvement tooling Not directly project related, like Docker, Homebrew... v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

In many secure environments, you can download things from your web browser, but you can't download our binary from our script.

When the script encounters an error while trying to download the binary, it would be nice if we could send a nice error message explaining what you should do.
Something in the terms of

Error: Could not download the meilisearch binary. Open this link [link] in your browser.
@irevoire irevoire added this to the v1.0.0 milestone Nov 14, 2022
@irevoire irevoire added the enhancement New feature or improvement label Nov 14, 2022
@curquiza curquiza self-assigned this Nov 14, 2022
@curquiza curquiza added the tooling Not directly project related, like Docker, Homebrew... label Nov 14, 2022
@curquiza curquiza mentioned this issue Nov 30, 2022
Merged
@curquiza curquiza linked a pull request Nov 30, 2022 that will close this issue
Improve download-latest.sh script: integrate apple-silicon binary #3169
Merged
bors bot added a commit that referenced this issue Dec 1, 2022
@bors @curquiza
Merge #3169
7e31466 
3169: Improve download-latest.sh script: integrate apple-silicon binary r=curquiza a=curquiza

Fixes multiples issues: #3044, #3027, #2613, #3014


Improvement/Addition
- #3044
- #3027

Simplification
- With #3014, we removed the complex part to get the latest version of Meilisearch we can now get directly with the GitHub API

Bug fixes:
- Should remove the problem the users encountered in this issue (#2613) because the related part has been removed from the script

Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
@bors bors bot closed this as completed in #3169 Dec 1, 2022
@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curquiza curquiza

Labels
enhancement New feature or improvement tooling Not directly project related, like Docker, Homebrew... v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Improve download-latest.sh script: integrate apple-silicon binary meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot