Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly restrict log level options to those that are documented #3292

Closed
loiclec opened this issue Jan 3, 2023 · 0 comments · Fixed by #3293
Closed

Explicitly restrict log level options to those that are documented #3292

loiclec opened this issue Jan 3, 2023 · 0 comments · Fixed by #3293
Labels
breaking change The related changes are breaking for the users enhancement New feature or improvement v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@loiclec
Copy link
Contributor

loiclec commented Jan 3, 2023 •
edited
Loading

See: https://docs.meilisearch.com/learn/configuration/instance_options.html#log-level

Currently we forward the given log level as-is to env_logger's builder. This inadvertently makes env_logger's API part of meilisearch's interface. We should be more explicit in the code about the accepted log levels.
@loiclec loiclec added the enhancement New feature or improvement label Jan 3, 2023
@loiclec loiclec added this to the v1.0.0 milestone Jan 3, 2023
@curquiza curquiza added the breaking change The related changes are breaking for the users label Jan 3, 2023
loiclec added a commit that referenced this issue Jan 3, 2023
@loiclec
Explicitly restrict log level options to those that are documented
21058d8 
Fixes #3292
loiclec added a commit that referenced this issue Jan 3, 2023
@loiclec
Explicitly restrict log level options to those that are documented
83a8ac2 
Fixes #3292
loiclec added a commit that referenced this issue Jan 3, 2023
@loiclec
Explicitly restrict log level options to those that are documented
70b2c41 
Fixes #3292
@loiclec loiclec mentioned this issue Jan 3, 2023
Merged
bors bot added a commit that referenced this issue Jan 4, 2023
@bors @loiclec
Merge #3293
12c3d43 
3293: Explicitly restrict log level options to those that are documented r=loiclec a=loiclec

Fixes #3292





Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
@bors bors bot closed this as completed in d082ded Jan 4, 2023
@curquiza curquiza mentioned this issue Jan 4, 2023
Merged
@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change The related changes are breaking for the users enhancement New feature or improvement v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Explicitly restrict log level options to those that are documented meilisearch/meilisearch
3 participants
@loiclec @curquiza @meili-bot