Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can create an API-key without an expires_at #3338

Closed
irevoire opened this issue Jan 12, 2023 · 1 comment
Closed

We can create an API-key without an expires_at #3338

irevoire opened this issue Jan 12, 2023 · 1 comment
Assignees
@loiclec
Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

On the latest RC it's possible to create an API-key without an expires_at.
That shouldn't be possible
@irevoire irevoire added the bug Something isn't working as expected label Jan 12, 2023
@irevoire irevoire added this to the v1.0.0 milestone Jan 12, 2023
@irevoire irevoire mentioned this issue Jan 12, 2023
Merged
bors bot added a commit that referenced this issue Jan 17, 2023
@bors @loiclec
Merge #3339
41a9702 
3339: Continued deserr integration r=irevoire a=loiclec

Fix #3337
Fix #3338

1. Add new error codes that should have been implemented earlier:
- `MissingApiKeyActions`
- `MissingApiKeyExpiresAt`
- `MissingApiKeyIndexes`
- `MissingSwapIndexes`

2. Fix a bug where it was possible to create an API key without specifying the value of `expiresAt`

3. Improve the error messages generated by deserr. Have specific error messages for JSON and QueryParam deserialisation errors.

4. Improve error tests by passing query params as arguments to `GET` routes directly instead of using an intermediary JSON object

5. [Use invalid_index_uid error code in more places](e225608)

Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
@curquiza
Copy link
Member

Fixed by #3339

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loiclec loiclec

Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
4 participants
@loiclec @irevoire @curquiza @meili-bot