Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing the swap-indexes #3340

Closed
3 tasks done
irevoire opened this issue Jan 12, 2023 · 1 comment
Closed
3 tasks done

Testing the swap-indexes #3340

irevoire opened this issue Jan 12, 2023 · 1 comment
Assignees
@irevoire
Labels
maintenance Issue about maintenance (CI, tests, refacto...) skip changelog The PR will not appear in the release changelogs v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

irevoire commented Jan 12, 2023 •
edited
Loading

Currently, there are zero (0) integration tests on the swap-indexes features.
(there is a lot of test in the index-scheduler but no integration tests)

  • Ensure the feature works as expected
    • When swapping two indexes their task history should be updated as well
  • Ensure all the good errors messages are returned when they're supposed to and with the good error codes
@irevoire irevoire self-assigned this Jan 12, 2023
@irevoire irevoire added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 12, 2023
@irevoire irevoire added this to the v1.0.0 milestone Jan 12, 2023
@irevoire irevoire added the skip changelog The PR will not appear in the release changelogs label Jan 12, 2023
@irevoire irevoire mentioned this issue Jan 18, 2023
Merged
bors bot added a commit that referenced this issue Jan 18, 2023
@bors @irevoire @loiclec
Merge #3341
6f7e0c4 
3341: add functionnal + error tests on the swap_indexes route and fix a confusing error message r=loiclec a=irevoire

Fix #3340
Fix part of #3325
Fix #3381

Test both the functionality and the error codes

Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
@curquiza
Copy link
Member

Fixed by #3341

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
maintenance Issue about maintenance (CI, tests, refacto...) skip changelog The PR will not appear in the release changelogs v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
3 participants
@irevoire @curquiza @meili-bot