Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /indexes/:uid/documents gets the wrong error code when an error happens on the offset #3371

Closed
Tracked by #3352
irevoire opened this issue Jan 18, 2023 · 1 comment · Fixed by #3373
Closed
Tracked by #3352

GET /indexes/:uid/documents gets the wrong error code when an error happens on the offset #3371

irevoire opened this issue Jan 18, 2023 · 1 comment · Fixed by #3373
Assignees
@irevoire
Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

No description provided.

@irevoire irevoire mentioned this issue Jan 18, 2023
Closed
22 tasks
@irevoire irevoire self-assigned this Jan 18, 2023
@irevoire irevoire mentioned this issue Jan 18, 2023
Merged
@irevoire irevoire linked a pull request Jan 18, 2023 that will close this issue
fix a wrong error code and add tests on the document resource #3373
Merged
@irevoire irevoire added bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch labels Jan 18, 2023
@irevoire irevoire added this to the v1.0.0 milestone Jan 18, 2023
bors bot added a commit that referenced this issue Jan 18, 2023
@bors @irevoire @Kerollmops
Merge #3370 #3373 #3375
3e5b3df 
3370: make the swap indexes not found errors return an IndexNotFound error-code r=irevoire a=irevoire

Fix #3368

3373: fix a wrong error code and add tests on the document resource r=irevoire a=irevoire

Fix #3371

3375: Avoid deleting all task invalid canceled by r=irevoire a=Kerollmops

Fixes #3369 by making sure that at least one `canceledBy` task filter parameter matches something.

Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Kerollmops <clement@meilisearch.com>
@curquiza
Copy link
Member

curquiza commented Jan 18, 2023 •
edited

Fixed by #3373

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix a wrong error code and add tests on the document resource meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot