Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While using the facets parameter of the search it returns a bad request when everything is good except your field is not filterable #3384

Closed
Tracked by #3352
curquiza opened this issue Jan 18, 2023 · 1 comment · Fixed by #3389
Closed
Tracked by #3352

While using the facets parameter of the search it returns a bad request when everything is good except your field is not filterable #3384

curquiza opened this issue Jan 18, 2023 · 1 comment · Fixed by #3389
Assignees
@dureuill
Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@curquiza
Copy link
Member

No description provided.

@curquiza curquiza mentioned this issue Jan 18, 2023
Closed
22 tasks
@curquiza curquiza added this to the v1.0.0 milestone Jan 18, 2023
@curquiza curquiza added the bug Something isn't working as expected label Jan 18, 2023
@dureuill dureuill self-assigned this Jan 19, 2023
@dureuill dureuill mentioned this issue Jan 19, 2023
Merged
3 tasks
bors bot added a commit that referenced this issue Jan 19, 2023
@bors @dureuill
Merge #3389
a1e9c44 
3389: Return `invalid_search_facets` rather than `bad_request` when using facet on a non filterable attribute r=irevoire a=dureuill

# Pull Request

## Related issue

Fixes #3384

## What does the PR does

- title
- also adds a test

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@dureuill
Copy link
Contributor

/shrug Somehow didn't close automatically after #3389

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dureuill dureuill

Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
3 participants
@curquiza @dureuill @meili-bot