Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When searching and using the facets on a non filterable field, the message should indicate the available filterableAttributes or saying there is none. Take example on the filter or sort #3390

Closed
Tracked by #3352
dureuill opened this issue Jan 19, 2023 · 1 comment · Fixed by #3395
Closed
Tracked by #3352

When searching and using the facets on a non filterable field, the message should indicate the available filterableAttributes or saying there is none. Take example on the filter or sort #3390

dureuill opened this issue Jan 19, 2023 · 1 comment · Fixed by #3395
Assignees
@dureuill
Labels
bug Something isn't working as expected milli Related to the milli workspace v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@dureuill
Copy link
Contributor

No description provided.

@dureuill dureuill mentioned this issue Jan 19, 2023
Closed
22 tasks
@dureuill dureuill self-assigned this Jan 19, 2023
@curquiza curquiza added this to the v1.0.0 milestone Jan 19, 2023
This was referenced Jan 19, 2023
Merged
Merged
@curquiza curquiza added bug Something isn't working as expected milli Related to the milli workspace labels Jan 19, 2023
@curquiza curquiza linked a pull request Jan 19, 2023 that will close this issue
Indicate filterable attributes in facet distributions when user requests a non filterable one. #3395
Merged
3 tasks
bors bot added a commit to meilisearch/milli that referenced this issue Jan 19, 2023
@bors @dureuill
Merge #766
e7c0617 
766: Indicate filterable attributes when the user sets a non filterable attribute in facet distributions r=irevoire a=dureuill

# Pull Request

## Related issue
Related to meilisearch/meilisearch#3390

## What does this PR do?
- Title

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
bors bot added a commit that referenced this issue Jan 23, 2023
@bors @dureuill
@ManyTheFish @irevoire
Merge #3395
74747b6 
3395: Indicate filterable attributes in facet distributions when user requests a non filterable one. r=irevoire a=dureuill

# Pull Request

## Related issue
Fixes #3390 

## What does this PR do?
- bump milli & deserr
- Update and add tests

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
Co-authored-by: ManyTheFish <many@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Fixed by #3395

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dureuill dureuill

Labels
bug Something isn't working as expected milli Related to the milli workspace v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
3 participants
@curquiza @dureuill @meili-bot