Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For all the fields that expect an usize, if we send a negative integer we can see the word usize appear which doesn’t mean anything for most people. We should write « positive integer » #3394

Closed
Tracked by #3352
irevoire opened this issue Jan 19, 2023 · 1 comment · Fixed by #3396
Closed
Tracked by #3352

For all the fields that expect an usize, if we send a negative integer we can see the word usize appear which doesn’t mean anything for most people. We should write « positive integer » #3394

irevoire opened this issue Jan 19, 2023 · 1 comment · Fixed by #3396
Assignees
@irevoire
Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

No description provided.

@irevoire irevoire mentioned this issue Jan 19, 2023
Closed
22 tasks
@irevoire irevoire self-assigned this Jan 19, 2023
@irevoire irevoire added the error handler Issues related to the returned errors in Meilisearch label Jan 19, 2023
@irevoire irevoire added this to the v1.0.0 milestone Jan 19, 2023
@irevoire irevoire mentioned this issue Jan 19, 2023
Merged
@irevoire irevoire linked a pull request Jan 19, 2023 that will close this issue
Update our error message about negative integer #3396
Merged
@curquiza curquiza added the bug Something isn't working as expected label Jan 19, 2023
bors bot added a commit that referenced this issue Jan 23, 2023
@bors @irevoire
Merge #3396
e664f09 
3396: Update our error message about negative integer r=dureuill a=irevoire

Fix #3394

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Closed by #3396

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Update our error message about negative integer meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot