Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a document addition fails its indexed_documents is not set to 0 #3411

Closed
irevoire opened this issue Jan 23, 2023 · 1 comment · Fixed by #3412
Closed

When a document addition fails its indexed_documents is not set to 0 #3411

irevoire opened this issue Jan 23, 2023 · 1 comment · Fixed by #3412
Assignees
@irevoire
Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

Describe the bug
☝️

Expected behavior
When indexing documents, if the task fails, the number of indexed documents should be 0.

The bug was present in v0.30.x
@irevoire irevoire added the bug Something isn't working as expected label Jan 23, 2023
@irevoire irevoire added this to the v1.0.0 milestone Jan 23, 2023
@irevoire irevoire self-assigned this Jan 23, 2023
@irevoire irevoire mentioned this issue Jan 23, 2023
Merged
@irevoire irevoire linked a pull request Jan 23, 2023 that will close this issue
When adding documents, trying to update the primary-key now throw an error #3412
Merged
bors bot added a commit that referenced this issue Jan 24, 2023
@bors @irevoire
Merge #3412
b3c2a4a 
3412: When adding documents, trying to update the primary-key now throw an error r=Kerollmops a=irevoire

While updating the test suite, I also noticed an issue with the indexed_documents value of failed tasks and had to update it. I also named a bunch of snapshots that had no name, sorry 😬

Fixes #3385
Fixes #3411

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Closed by #3412

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

When adding documents, trying to update the primary-key now throw an error meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot