Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a _geo field contains one extra unspecified field, an error should be throw #3414

Closed
Tracked by #3352
irevoire opened this issue Jan 24, 2023 · 1 comment · Fixed by #3415
Closed
Tracked by #3352

When a _geo field contains one extra unspecified field, an error should be throw #3414

irevoire opened this issue Jan 24, 2023 · 1 comment · Fixed by #3415
Assignees
@irevoire
Labels
breaking change The related changes are breaking for the users bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Milestone
v1.0.0

Comments

@irevoire
Copy link
Member

No description provided.

This was referenced Jan 24, 2023
Closed
Merged
bors bot added a commit to meilisearch/milli that referenced this issue Jan 24, 2023
@bors @irevoire
Merge #772
4e4d8df 
772: Throw an error on unknown fields specified in the _geo field r=irevoire a=irevoire

Fix parts of meilisearch/meilisearch#3414

Co-authored-by: Tamo <tamo@meilisearch.com>
@irevoire irevoire mentioned this issue Jan 24, 2023
Merged
@irevoire irevoire added this to the v1.0.0 milestone Jan 24, 2023
@irevoire irevoire self-assigned this Jan 24, 2023
@irevoire irevoire added bug Something isn't working as expected breaking change The related changes are breaking for the users labels Jan 24, 2023
@irevoire irevoire linked a pull request Jan 24, 2023 that will close this issue
Test all the errors of wrong _geo field and bump milli #3415
Merged
bors bot added a commit that referenced this issue Jan 25, 2023
@bors @irevoire
Merge #3415
583f8ba 
3415: Test all the errors of wrong `_geo` field and bump milli r=dureuill a=irevoire

## Attention to reviewer

The first commit is only a refactoring of the test suite to use snapshot tests everywhere instead of `assert_eq`.
It doesn’t change the content of anything and there is probably nothing to review. I just made it for maintenance purpose in the future.


Fix #3414

Co-authored-by: Tamo <tamo@meilisearch.com>
bors bot added a commit that referenced this issue Jan 25, 2023
@bors @irevoire
Merge #3415
4549e0a 
3415: Test all the errors of wrong `_geo` field and bump milli r=dureuill a=irevoire

## Attention to reviewer

The first commit is only a refactoring of the test suite to use snapshot tests everywhere instead of `assert_eq`.
It doesn’t change the content of anything and there is probably nothing to review. I just made it for maintenance purpose in the future.


Fix #3414

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Closed by #3415

@meili-bot meili-bot added the v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
breaking change The related changes are breaking for the users bug Something isn't working as expected v1.0.0 PRs/issues solved in v1.0.0 released on 2023-02-06
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Test all the errors of wrong _geo field and bump milli meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot