Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot file permission issues #3507

Closed
Magorx15 opened this issue Feb 17, 2023 · 5 comments · Fixed by #3561
Closed

Snapshot file permission issues #3507

Magorx15 opened this issue Feb 17, 2023 · 5 comments · Fixed by #3561
Labels
bug Something isn't working as expected v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03
Milestone
v1.1.0

Comments

@Magorx15
Copy link

Describe the bug
After creating a snapshot, data.ms.snapshot file has incorrect permissions, unable to interact with it without sudo or as root

To Reproduce
docker run -e MEILI_SNAPSHOT_DIR="/snapshots" -e MEILI_SCHEDULE_SNAPSHOT=true -e MEILI_SNAPSHOT_INTERVAL_SEC=10 getmeili/meilisearch:v0.29.0
The snapshot in /snapshots folder has correct permissions (see screenshots)

docker run -e MEILI_SNAPSHOT_DIR="/snapshots" -e MEILI_SCHEDULE_SNAPSHOT=true -e MEILI_SNAPSHOT_INTERVAL_SEC=10 getmeili/meilisearch:v0.30.0
The snapshot in /snapshots folder has incorrect permissions (see screenshots)

Screenshots
Using v0.29.0
image
Using v0.30.0-v1.0.0
image

Meilisearch version: v0.29.0, v0.30.0-v1.0.0
@curquiza curquiza added the support Issues related to support questions label Feb 20, 2023
@oluademola
Copy link

Hello @Magorx15. Thank you for informing us about this problem. Indeed the snapshot permission file changed from v0.30 upward. I'm not sure if this change was intended or not; however, I'd discuss it with the team and get back to you. I understand this might trigger permission issues, but I would like to know specifically how this change impacts you. Thanks again.

@Magorx15
Copy link
Author

We are trying to upload the snapshot to somewhere else (and therefore we need read permission) which obviously fails as it needs root user for that

@Magorx15
Copy link
Author

Magorx15 commented Mar 3, 2023

Any updates @oluademola?

@irevoire irevoire mentioned this issue Mar 6, 2023
Merged
@irevoire
Copy link
Member

irevoire commented Mar 6, 2023 •
edited by curquiza

Hey @Magorx15, yeah, this was definitely an issue on our side; it should be fixed for the next release!

First RCs coming this week, and official release will be 3rd April!

Thanks for the report 💯

@irevoire irevoire added bug Something isn't working as expected and removed support Issues related to support questions labels Mar 6, 2023
@irevoire irevoire added this to the v1.1.0 milestone Mar 6, 2023
bors bot added a commit that referenced this issue Mar 7, 2023
@bors @irevoire
Merge #3561
370d88f 
3561: Fix the snapshots permissions on unix system r=irevoire a=irevoire

# Pull Request

## Related issue
Fixes #3507

The snapshot permissions were wrong after the v0.30 and the huge refacto of the index scheduler.
Fix this issue + add a test on the permissions on unix

Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

curquiza commented Mar 7, 2023

Fixed by #3561, will be released in v1.1.0-rc.1 by the end of the week or at the beginning of next week

@curquiza curquiza closed this as completed Mar 7, 2023
@meili-bot meili-bot added the v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03 label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected v1.1.0 PRs/issues solved in v1.1.0 released on 2023-04-03
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Fix the snapshots permissions on unix system meilisearch/meilisearch
5 participants
@irevoire @curquiza @meili-bot @oluademola @Magorx15