Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meilisearch returns a wrong documentDeletionByFilter in the error message of the task queue filters #3791

Closed
irevoire opened this issue May 30, 2023 · 1 comment · Fixed by #3792
Closed

Meilisearch returns a wrong documentDeletionByFilter in the error message of the task queue filters #3791

irevoire opened this issue May 30, 2023 · 1 comment · Fixed by #3792
Assignees
@irevoire
Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Milestone
v1.2.0

Comments

@irevoire
Copy link
Member

That was introduced in the latest release

% mieli task --types bernese
{
  "message": "Invalid value in parameter `types`: `bernese` is not a valid task type. Available types are `documentAdditionOrUpdate`, `documentDeletion`, `documentDeletionByFilter`, `settingsUpdate`, `indexCreation`, `indexDeletion`, `indexUpdate`, `indexSwap`, `taskCancelation`, `taskDeletion`, `dumpCreation`, `snapshotCreation`.",
  "code": "invalid_task_types",
  "type": "invalid_request",
  "link": "https://docs.meilisearch.com/errors#invalid_task_types"
}
@irevoire irevoire added the error handler Issues related to the returned errors in Meilisearch label May 30, 2023
@irevoire irevoire added this to the v1.2.0 milestone May 30, 2023
@irevoire irevoire self-assigned this May 30, 2023
@irevoire irevoire added the bug Something isn't working as expected label May 30, 2023
@irevoire irevoire mentioned this issue May 30, 2023
Merged
meili-bors bot added a commit that referenced this issue May 30, 2023
@meili-bors @irevoire
Merge #3792
d963b5f 
3792: fix the type of the document deletion by filter tasks r=dureuill a=irevoire

# Pull Request

## Related issue
Fixes #3791

## What does this PR do?
- Hide the deleteDocumentByFilter internal type from the users.


Co-authored-by: Tamo <tamo@meilisearch.com>
@gillian-meilisearch gillian-meilisearch linked a pull request May 31, 2023 that will close this issue
fix the type of the document deletion by filter tasks #3792
Merged
@gillian-meilisearch
Copy link
Contributor

Issue closed by #3792 and will be included in v1.2.0-rc.4

@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected error handler Issues related to the returned errors in Meilisearch v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

fix the type of the document deletion by filter tasks meilisearch/meilisearch
3 participants
@irevoire @meili-bot @gillian-meilisearch