Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopword settingsUpdate FST error #3893

Closed
Magorx15 opened this issue Jul 6, 2023 · 3 comments · Fixed by #3904
Closed

stopword settingsUpdate FST error #3893

Magorx15 opened this issue Jul 6, 2023 · 3 comments · Fixed by #3904
Labels
bug Something isn't working as expected v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31
Milestone

Comments

@Magorx15
Copy link

Magorx15 commented Jul 6, 2023

Describe the bug
When i set the stopwords of an index with certain stopwords it gives an internal FST error.
Examples that work:

{
    "stopWords":
    [
        "akkor"
    ]
}
{
    "stopWords":
    [
        "akár"
    ]
}

Doesn't work:

{
    "stopWords":
    [
        "akkor",
        "akár"
    ]
}

The error that i am getting:

"error": {
    "message": "internal: FST error.",
    "code": "internal",
    "type": "internal",
    "link": "https://docs.meilisearch.com/errors#internal"
}

To Reproduce
Steps to reproduce the behavior:

docker run -p 7700:7700 getmeili/meilisearch:v1.3.0-rc.0
curl -X POST 'http://localhost:7700/indexes' -H 'Content-Type: application/json' --data-binary '{"uid": "test", "primaryKey": "id"}'
curl -X PATCH 'http://localhost:7700/indexes/test/settings' -H 'Content-Type: application/json' --data-binary '{"stopWords": ["akkor", "akár"]}'

Meilisearch version:
v1.3.0-rc.0

@gillian-meilisearch gillian-meilisearch added the bug Something isn't working as expected label Jul 6, 2023
@gillian-meilisearch
Copy link
Contributor

Hi @Magorx15, thanks so much for spotting this, much appreciated 🙌 we'll take a look into it.

@dureuill
Copy link
Contributor

dureuill commented Jul 10, 2023

Hi 👋

Reproduced. I have a fix, see #3904

Thank you for the very detailed report 😃

@gillian-meilisearch gillian-meilisearch linked a pull request Jul 10, 2023 that will close this issue
@gillian-meilisearch gillian-meilisearch added this to the v1.3.0 milestone Jul 10, 2023
meili-bors bot added a commit that referenced this issue Jul 10, 2023
3904: Sort by lexicographic order after normalization r=dureuill a=dureuill

# Pull Request

## Related issue
Fixes #3893

## What does this PR do?
- Re-sort stop words after normalization so they're not sent out-of-order to the FST


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@gillian-meilisearch
Copy link
Contributor

Thanks again for finding this Magorx15 ❤️ This issue has been resolved and will be available in the next release candidate of v1.3 to test out.

@meili-bot meili-bot added the v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31 label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected v1.3.0 PRs/issues solved in v1.3.0 released on 2023-07-31
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants