Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus meilisearch_nb_tasks seems to report nothing #3972

Closed
gmourier opened this issue Aug 4, 2023 · 3 comments · Fixed by #3976
Closed

Prometheus meilisearch_nb_tasks seems to report nothing #3972

gmourier opened this issue Aug 4, 2023 · 3 comments · Fixed by #3976
Labels
bug Something isn't working as expected v1.3.1 PRs/issues solved in v1.3.1 released on 2023-08-14
Milestone
v1.3.1

Comments

@gmourier
Copy link
Member

gmourier commented Aug 4, 2023 •
edited

Mentioned by @gabrieltz here

"I upgraded to version 1.3.0 yesterday and used some of the new metrics, however i noticed that the metric meilisearch_nb_tasks{instance="XXXXXX:7700", job="meilisearch", kind="statuses", value="processing"} is zero all the time, even while importing a few million documents in over 700 batches. The /tasks endpoint values were correct though"
@irevoire irevoire added the bug Something isn't working as expected label Aug 7, 2023
@irevoire
Copy link
Member

irevoire commented Aug 7, 2023 •
edited

I was able to reproduce it; it’s effectively a bug

@irevoire irevoire mentioned this issue Aug 7, 2023
Merged
@curquiza curquiza added this to the v1.3.1 milestone Aug 8, 2023
@curquiza
Copy link
Member

curquiza commented Aug 8, 2023

Will be fixed in v1.3.1 and release this week or next week

meili-bors bot added a commit that referenced this issue Aug 10, 2023
@meili-bors @irevoire
Merge #3976
ef3d098 
3976: Fix the get stats method r=ManyTheFish a=irevoire

# Pull Request

- The get stats method of the index-scheduler was not using at all the processing tasks. That was returning a wrong number of enqueued tasks and 0 processing tasks.
- Added a test
- Currently this method was **ONLY** used to compute the `meilisearch_nb_tasks` field of the **experimental feature** metrics.

## Related issue
Fixes #3972


Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Fixed by #3976

@meili-bot meili-bot added the v1.3.1 PRs/issues solved in v1.3.1 released on 2023-08-14 label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected v1.3.1 PRs/issues solved in v1.3.1 released on 2023-08-14
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging a pull request may close this issue.

Fix the get stats method meilisearch/meilisearch
4 participants
@gmourier @irevoire @curquiza @meili-bot