Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite is failing with Rust nightly #3988

Closed
curquiza opened this issue Aug 9, 2023 · 1 comment · Fixed by #3990
Closed

Test suite is failing with Rust nightly #3988

curquiza opened this issue Aug 9, 2023 · 1 comment · Fixed by #3990
Labels
contribution accepted This issue accepts external contributions good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25
Milestone

Comments

@curquiza
Copy link
Member

curquiza commented Aug 9, 2023

We run our test suite on every PR with a stable version of Rust, and every day with the nightly version of Rust

Our CI is currently failing with Rust nightly
https://github.com/meilisearch/meilisearch/actions/runs/5805090341/job/15735677435

   Compiling milli v1.3.0 (/__w/meilisearch/meilisearch/milli)
   Compiling meilisearch-types v1.3.0 (/__w/meilisearch/meilisearch/meilisearch-types)
   Compiling actix-cors v0.6.4
error: call to `.borrow()` on a reference in this situation does nothing
  --> meilisearch-types/src/document_formats.rs:45:54
   |
45 |             Self::MalformedPayload(me, b) => match me.borrow() {
   |                                                      ^^^^^^^^^ help: remove this redundant call
   |
   = note: the type `milli::documents::Error` does not implement `Borrow`, so calling `borrow` on `&milli::documents::Error` copies the reference, which does not do anything and can be removed
   = note: `-D noop-method-call` implied by `-D warnings`

error: could not compile `meilisearch-types` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
Error: The process '/github/home/.cargo/bin/cargo' failed with exit code 101
@curquiza curquiza added bug Something isn't working as expected good first issue Good for newcomers contribution accepted This issue accepts external contributions labels Aug 9, 2023
@curquiza curquiza changed the title Test suite is failing with nightly Test suite is failing with Rust nightly Aug 9, 2023
@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Aug 9, 2023
@JannisK89
Copy link
Contributor

Hi! I submited a PR for this issue. Please let me know if there is anything else I can do to improve the PR. Thanks :)

meili-bors bot added a commit that referenced this issue Aug 10, 2023
3989: Improve test suite CI for manual trigger events r=irevoire a=curquiza

# Why?

To be able to test #3988 before merging the PR solving it

# How do we ensure this PR works?

I triggered `workflow_dispatch` (i.e. manual trigger) on this branch, and we can see all the jobs have been triggered (even if some of them are failing -> it's another issue)
https://github.com/meilisearch/meilisearch/actions/runs/5810609073

We can see the tests triggered by the PR are restricted as expected: https://github.com/meilisearch/meilisearch/actions/runs/5810605977

Co-authored-by: curquiza <clementine@meilisearch.com>
@curquiza curquiza added this to the v1.4.0 milestone Aug 10, 2023
@curquiza curquiza removed the bug Something isn't working as expected label Aug 10, 2023
@meili-bors meili-bors bot closed this as completed in 00bd7bd Aug 10, 2023
@meili-bot meili-bot added the v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution accepted This issue accepts external contributions good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants