Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task register of SwapIndexes is called in an asyncronous context #4040

Closed
irevoire opened this issue Sep 7, 2023 · 1 comment · Fixed by #4041
Closed

task register of SwapIndexes is called in an asyncronous context #4040

irevoire opened this issue Sep 7, 2023 · 1 comment · Fixed by #4041
Assignees
@irevoire
Labels
bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25
Milestone
v1.4.0

Comments

@irevoire
Copy link
Member

irevoire commented Sep 7, 2023

Describe the bug
When registering a swap indexes task, we do it in the asynchronous context without spawning a blocking task.
That could theorically starve the main thread if we end up being blocked by something that takes time in lmdb.

Meilisearch version:
Since the introduction of the swap index feature in v0.30
@irevoire irevoire added bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) labels Sep 7, 2023
@irevoire irevoire added this to the v1.4.0 milestone Sep 7, 2023
@irevoire irevoire self-assigned this Sep 7, 2023
@irevoire irevoire mentioned this issue Sep 7, 2023
Merged
meili-bors bot added a commit that referenced this issue Sep 7, 2023
@meili-bors @irevoire
Merge #4041
b9ad59c 
4041: Register the swap indexe task in a spawn blocking to be sure to never… r=ManyTheFish a=irevoire

# Pull Request

## Related issue
Fixes #4040

## What does this PR do?
- Register the swap indexes task in a spawn blocking task

Co-authored-by: Tamo <tamo@meilisearch.com>
@irevoire irevoire linked a pull request Sep 7, 2023 that will close this issue
Register the swap indexe task in a spawn blocking to be sure to never… #4041
Merged
@curquiza
Copy link
Member

curquiza commented Sep 7, 2023

Fixed by #4041
will be released in v1.4.0-rc.1

@curquiza curquiza closed this as completed Sep 7, 2023
@meili-bot meili-bot added the v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25 label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) v1.4.0 PRs/issues solved in v1.4.0 released on 2023-09-25
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Register the swap indexe task in a spawn blocking to be sure to never… meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot