Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the dump creation cancellable #4157

Closed
irevoire opened this issue Oct 23, 2023 · 1 comment · Fixed by #4208
Closed

Make the dump creation cancellable #4157

irevoire opened this issue Oct 23, 2023 · 1 comment · Fixed by #4208
Labels
bug Something isn't working as expected documentation Related to the documentation of this repository v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 version upgrade Anything related to the way we update a meilisearch instance
Milestone
v1.6.0

Comments

@irevoire
Copy link
Member

Currently, there is no point in a dump creation where we can cancel a dump creation.

That means if a dump creation is taking a really long time to process, the whole engine is stuck, registering tasks it can't process forever.
That's a real issue because we've encountered some dump creations taking days to process, during which a lot of enqueued tasks stacked up, and then the whole instance was dying under its huge number of enqueued tasks.
@irevoire irevoire added bug Something isn't working as expected version upgrade Anything related to the way we update a meilisearch instance labels Oct 23, 2023
@irevoire irevoire mentioned this issue Oct 23, 2023
Open
6 tasks
@irevoire irevoire added this to the v1.5.0 milestone Oct 23, 2023
@curquiza curquiza removed this from the v1.5.0 milestone Oct 23, 2023
@curquiza curquiza added this to the v1.6.0 milestone Nov 2, 2023
@irevoire irevoire mentioned this issue Nov 14, 2023
Merged
@meili-bors meili-bors bot closed this as completed in 2b5d904 Nov 14, 2023
@curquiza
Copy link
Member

@meilisearch/docs-team here, I don't know if it's something you mentioned in the docs

@curquiza curquiza added the documentation Related to the documentation of this repository label Dec 12, 2023
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected documentation Related to the documentation of this repository v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 version upgrade Anything related to the way we update a meilisearch instance
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Makes the dump cancellable meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot