Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failing with --no-default-features #4441

Closed
curquiza opened this issue Feb 26, 2024 · 4 comments · Fixed by #4451
Closed

CI failing with --no-default-features #4441

curquiza opened this issue Feb 26, 2024 · 4 comments · Fixed by #4451
Assignees
@ManyTheFish
Labels
bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11
Milestone
v1.7.0

Comments

@curquiza
Copy link
Member

Describe the bug
CI runing with cargo build --locked --release --no-default-features --all fails on release-v1.7.0

Expected behavior
No CI failing

Screenshots
https://github.com/meilisearch/meilisearch/actions/runs/8045912784/job/21972108739

Capture d’écran 2024-02-26 à 09 46 43

Meilisearch version:
Failing on release-v1.7.0.
@curquiza curquiza added bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) labels Feb 26, 2024
@curquiza curquiza added this to the v1.7.0 milestone Feb 26, 2024
@dureuill
Copy link
Contributor

dureuill commented Feb 28, 2024 •
edited

Hello @curquiza 👋

I do not reproduce on branch release-v1.7.0 (147a67dc8266c77479d86f13a2d7ac0d7054c135), on an Ubuntu 18.04 (docker).

Commands I ran:

# outside docker
docker run --rm -it  ubuntu:18.04 /bin/bash
# inside docker
apt update
apt install -y git curl build-essential
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs -S > rustup.sh
chmod +x ./rustup.sh
./rustup.sh -y --profile minimal
source "$HOME/.cargo/env"
git clone https://github.com/meilisearch/meilisearch
cd meilisearch
git checkout release-v1.7.0
RUSTFLAGS="-D warnings" cargo build --release --locked --no-default-features --all

@curquiza
Copy link
Member Author

The problem is the CI is not working on release-v1.7.0 as I linked in the issue 😢
https://github.com/meilisearch/meilisearch/actions/runs/8045912784

Here is the CI manifest: https://github.com/meilisearch/meilisearch/blob/main/.github/workflows/test-suite.yml

@curquiza
Copy link
Member Author

I re run it on release-v1.7.0, still does not work: https://github.com/meilisearch/meilisearch/actions/runs/8082966997/job/22084953481

@dureuill dureuill mentioned this issue Feb 28, 2024
Merged
meili-bors bot added a commit that referenced this issue Feb 29, 2024
@meili-bors @dureuill
Merge #4451
a96b45d 
4451: Fix nightly build r=dureuill a=dureuill

# Pull Request

## Related issue
Fixes #4441 

## What does this PR do?
- Change imports following rust-lang/rust#117772

## Note

This one is going to be annoying a bit until the lint stabilizes:

- We only get the warning on nightly, so we will discover them when it runs in the CI that uses the nightly compiler (not on regular PRs)
- There's the case of `TryInto`/`TryFrom` traits. They have been added to the prelude in Rust edition 2021, so it means that `use`ing them is a warning on nightly for 2021 edition crates (most crates), but not `use`ing them is an error anywhere for 2018 Rust edition crates, such as `milli`

Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@dureuill
Copy link
Contributor

Fixed by #4451

@dureuill dureuill mentioned this issue Feb 29, 2024
Merged
meili-bors bot added a commit that referenced this issue Feb 29, 2024
@meili-bors @dureuill
Merge #4453
f4a6261 
4453: Don't test on nightly r=dureuill a=dureuill

# Pull Request

## Related issue
Fixes #4441 better 😅 

## What does this PR do?
- No longer run tests on nightly

The motivation for this change is that we are now updating Rust at fixed points in time, and so no longer need nightly runs to ensure that a change won't get into stable and break our build at the worst possible moment.


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@meili-bot meili-bot added the v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11 label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManyTheFish ManyTheFish

Labels
bug Something isn't working as expected maintenance Issue about maintenance (CI, tests, refacto...) v1.7.0 PRs/issues solved in v1.7.0 released on 2024-03-11
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

Fix nightly build meilisearch/meilisearch
4 participants
@ManyTheFish @curquiza @dureuill @meili-bot