Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distinctAttribute at search #4611

Closed
8 tasks
curquiza opened this issue Apr 30, 2024 · 3 comments · Fixed by #4693
Closed
8 tasks

distinctAttribute at search #4611

curquiza opened this issue Apr 30, 2024 · 3 comments · Fixed by #4693
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations missing usage in PRD Description of the feature usage is missing in the PRD
Milestone
v1.9.0

Comments

@curquiza
Copy link
Member

curquiza commented Apr 30, 2024 •
edited
Loading

Related product team resources: PRD (internal only)

Motivation

Required by users

Usage

Being able to set up distinct attribute at search and not only on indexing side

https://meilisearch.notion.site/Set-distinctAttribute-at-search-usage-947187b312c04616a8ca8ef5bcc5c63c?pvs=74

TODO

Reminders when modifying the Setting API

  • Ensure the new setting route is at least tested by the test_setting_routes macro
  • Ensure Analytics are fully implemented
  • Ensure the dump serializing is consistent with the /settings route serializing, e.g., enums case can be different (camelCase in route and PascalCase in the dump)

Special cases when adding a setting for an experimental feature

  • ⚠️ API stability: The setting does not appear on the main settings route when the feature has never been enabled (e.g. mark it Unset when returned from the index in this situation. See an example)
  • The setting cannot be set when the feature is disabled, either by the main settings route or the subroute (see validate_settings function)
  • If possible, the setting is reset when the feature is disabled (hard if it requires reindexing)

Impacted teams

@meilisearch/docs-team @meilisearch/integration-team
@curquiza curquiza added enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation missing usage in PRD Description of the feature usage is missing in the PRD labels Apr 30, 2024
@curquiza curquiza added this to the v1.9.0 milestone Apr 30, 2024
@akhil007jainth
Copy link

This is important in my opinion. Nice feature to have.

@curquiza curquiza added the impacts integrations This issue involves changes in the Meilisearch's integrations label May 29, 2024
@Kerollmops Kerollmops mentioned this issue Jun 11, 2024
Merged
3 tasks
@guimachiavelli guimachiavelli mentioned this issue Jun 11, 2024
Closed
1 task
@bradenmacdonald
Copy link

This will be very helpful for properly implementing facet keyword search among hierarchical facets: https://github.com/orgs/meilisearch/discussions/735#discussioncomment-9742969

@Kerollmops Kerollmops linked a pull request Jun 11, 2024 that will close this issue
Introduce distinct attributes at search time #4693
Merged
3 tasks
@curquiza curquiza mentioned this issue Jun 13, 2024
Open
37 tasks
meili-bors bot added a commit that referenced this issue Jun 17, 2024
@meili-bors @Kerollmops @irevoire
Merge #4693
22117db 
4693: Introduce distinct attributes at search time r=irevoire a=Kerollmops

This PR fixes #4611.

### To Do
- [x] Remove the `distinguishableAttributes` settings (not even a commit about that).
- [x] Use the `filterableAttributes` to be able to use the `distinct` parameter at search.
- [x] Work on the errors and make tests.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
meili-bors bot added a commit that referenced this issue Jun 18, 2024
@meili-bors @Kerollmops @irevoire
Merge #4693
e580d6b 
4693: Introduce distinct attributes at search time r=irevoire a=Kerollmops

This PR fixes #4611.

### To Do
- [x] Remove the `distinguishableAttributes` settings (not even a commit about that).
- [x] Use the `filterableAttributes` to be able to use the `distinct` parameter at search.
- [x] Work on the errors and make tests.

Co-authored-by: Clément Renault <clement@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member Author

Closed by #4693 and available in v1.9.0-rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations missing usage in PRD Description of the feature usage is missing in the PRD
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

Introduce distinct attributes at search time meilisearch/meilisearch
3 participants
@bradenmacdonald @curquiza @akhil007jainth