Improve script download-latest.sh
#1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 104 104
Lines 12113 12113
=======================================
Hits 9295 9295
Misses 2818 2818
Continue to review full report at Codecov.
|
Kerollmops
approved these changes
Nov 3, 2020
Comment on lines
-171
to
+172
| get_os | ||
| if [ "$?" -eq 1 ]; then | ||
|
|
||
| if ! get_os; then |
There was a problem hiding this comment.
I suppose this is fair, we were only testing that the get_os out was 1 instead of checking that it is simply different from 0, so...
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great tool!