Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy on Platform.sh option to README #1087

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

chadwcarlson
Copy link
Contributor

@chadwcarlson chadwcarlson commented Nov 17, 2020

We have had a lot of success using Meilisearch on our public documentation, and I've put together the "movies" demo to quickly show it off. Included in our template README is instructions for modifying the template deployment to make it production ready.

All the best.

As per CONTRIBUTING, related to #1086

closes #1086

@MarinPostma MarinPostma added this to the 12/2020 milestone Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1087 (0f4182b) into master (ef6b56d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1087   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files         104      104           
  Lines       12127    12127           
=======================================
  Hits         9282     9282           
  Misses       2845     2845           
Impacted Files Coverage Δ
meilisearch-core/src/bucket_sort.rs 81.34% <0.00%> (-0.06%) ⬇️
meilisearch-core/src/number.rs 31.78% <0.00%> (ø)
meilisearch-http/tests/common.rs 90.86% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a67862...0f4182b. Read the comment docs.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, that's a pleasure to work with you.
I accept this PR 🎉

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 19, 2020

Build succeeded:

@bors bors bot merged commit 6fff49b into meilisearch:master Nov 19, 2020
@ManyTheFish ManyTheFish removed the RFR label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying on Platform.sh
4 participants