[fix] Remove some clippy warnings #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
approved these changes
Nov 30, 2020
I agree that this could be useful bors r+ |
tryBuild succeeded: |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Dec 23, 2020
1113: [ci] Add all target to check r=LegendreM a=woshilapin Follow-up on #1100 (comment). If you disagree to add this, I'm totally fine to close this PR without merging (related to #1099). Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info> Co-authored-by: Many <legendre.maxime.isn@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jan 5, 2021
1113: [ci] Add all target to check r=MarinPostma a=woshilapin Follow-up on #1100 (comment). If you disagree to add this, I'm totally fine to close this PR without merging (related to #1099). Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info> Co-authored-by: Many <legendre.maxime.isn@gmail.com>
bors bot
added a commit
that referenced
this pull request
Mar 9, 2021
1113: [ci] Add all target to check r=MarinPostma a=woshilapin Follow-up on #1100 (comment). If you disagree to add this, I'm totally fine to close this PR without merging (related to #1099). Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1099
I'm also wondering if I should add
-- --deny warningsto the modified line intest.yml.