Fix mini dashboard #1755
Merged
Fix mini dashboard #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a fix to issue meilisearch#1750. As a part of the changes to solve this issue, the following changes have been made - 1. Route registration for static assets has been modified 2. the `mut` keyword on the `scope` has been removed.
curquiza
previously approved these changes
Oct 2, 2021
MarinPostma
reviewed
Oct 4, 2021
meilisearch-http/src/lib.rs
Outdated
| @@ -147,7 +147,7 @@ pub fn dashboard(config: &mut web::ServiceConfig, enable_frontend: bool) { | |||
|
|
|||
| if enable_frontend { | |||
| let generated = generated::generate(); | |||
| let mut scope = web::scope("/"); | |||
| let scope = web::scope("/"); | |||
There was a problem hiding this comment.
Suggested change
| let scope = web::scope("/"); |
you can remove this line, and the one at line 167, since they are now useless
MarinPostma
previously requested changes
Oct 4, 2021
|
All tests green :) thank you for this opportunity. |
curquiza
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Thank you so much @anirudhRowjee! Especially for your reactivity
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.
bors merge
MarinPostma
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a fix to issue #1750.
As a part of the changes to solve this issue, the following changes have
been made -
mutkeyword on thescopehas been removed.