Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty dump #1787

Merged
merged 1 commit into from Oct 27, 2021
Merged

Handle empty dump #1787

merged 1 commit into from Oct 27, 2021

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Oct 7, 2021

Fixes #1701

@curquiza
Copy link
Member

curquiza commented Oct 7, 2021 •
edited

I would rather this PR be merged into main (v0.24.0) to avoid bringing any problem just before the release (v0.23.0) :)

@curquiza curquiza added this to the v0.24.0 milestone Oct 7, 2021
@curquiza curquiza linked an issue Oct 7, 2021 that may be closed by this pull request
Dump import crashed when dump file is created out of empty MeiliSearch #1701
Closed
@irevoire irevoire changed the base branch from release-v0.23.0 to main October 7, 2021 16:58
@irevoire irevoire force-pushed the empty_dump branch 2 times, most recently from a2b6b08 to 1242f0e Compare October 11, 2021 20:44
@irevoire
Copy link
Member Author

@MarinPostma can we merge this PR? It works but do you think it's the right way to do it?

MarinPostma
MarinPostma approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm good with that

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 27, 2021

Build succeeded:

@bors bors bot merged commit d905bbf into main Oct 27, 2021
@bors bors bot deleted the empty_dump branch October 27, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarinPostma MarinPostma MarinPostma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

Dump import crashed when dump file is created out of empty MeiliSearch
3 participants
@irevoire @curquiza @MarinPostma