Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RUNs in Dockerfile #1817

Merged
merged 2 commits into from Oct 18, 2021
Merged

Improve RUNs in Dockerfile #1817

merged 2 commits into from Oct 18, 2021

Conversation

nfsec
Copy link
Contributor

@nfsec nfsec commented Oct 15, 2021

Align apk add commands between images.

@nfsec
One RUN less
23458de 
Align apk add commands between images.
@irevoire
Copy link
Member

I think we could also merge the apk update with the apk add what do you think?
Something like that:

RUN apk update --quiet && apk add -q --no-cache curl build-base

@nfsec
Copy link
Contributor Author

nfsec commented Oct 16, 2021

Good thinking. Changed.

@curquiza curquiza changed the title One RUN less Improve the RUNs in Dockerfile Oct 16, 2021
@curquiza curquiza changed the title Improve the RUNs in Dockerfile Improve RUNs in Dockerfile Oct 16, 2021
@curquiza curquiza added this to the v0.24.0 milestone Oct 16, 2021
irevoire
irevoire approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

curquiza
curquiza approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nfsec

bors merge

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

curquiza commented Oct 18, 2021 •
edited

Oh since the user branch does not exist anymore, I have to manually merge, once all the tests have passed

@curquiza curquiza merged commit e7e4ccf into meilisearch:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

@curquiza curquiza curquiza approved these changes

Assignees

@curquiza curquiza

Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nfsec @irevoire @curquiza