Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexation perfomances on mounted disk #1824

Merged
merged 2 commits into from Oct 18, 2021

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Oct 18, 2021

We were creating all of our tempfiles in data.ms directory, but when the database directory is stored in a mounted disk, tempfiles I/O throughput decreases, impacting the indexation time.

Now, only the persisting tempfiles will be created in the database directory. Other tempfiles will stay in the default tmpdir.

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nothing to say 👍
And good job for investigating that 😁
If you don't want to change anything else I think we can merge.

@curquiza curquiza added this to the v0.24.0 milestone Oct 18, 2021
@curquiza
Copy link
Member

Many, the hero of the mounted disk 🦸

@ManyTheFish
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 18, 2021

@bors bors bot merged commit 1c9cead into main Oct 18, 2021
@bors bors bot deleted the fix-indexation-perfomances-on-mounted-disk branch October 18, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants