New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error format and Definition #1848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
added
the
breaking change
The related changes are breaking for the users
label
Oct 25, 2021
ManyTheFish
force-pushed
the
error-format-and-definition
branch
from
October 27, 2021 09:12
6157454
to
d45064f
Compare
ManyTheFish
force-pushed
the
error-format-and-definition
branch
from
October 27, 2021 09:15
d45064f
to
0bade66
Compare
ManyTheFish
force-pushed
the
error-format-and-definition
branch
from
October 28, 2021 08:47
0bade66
to
c845d4c
Compare
ManyTheFish
force-pushed
the
error-format-and-definition
branch
from
October 28, 2021 08:48
c845d4c
to
7464720
Compare
MarinPostma
suggested changes
Oct 28, 2021
meilisearch-lib/src/index_controller/index_resolver/index_store.rs
Outdated
Show resolved
Hide resolved
Looks goo to me, as soon as we can bump milli, I'll approve. |
MarinPostma
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.