-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make matches work with numerical value #1893
Conversation
We should keep the same behavior as on a string where MeiliSearch does not match the whole word as well. The highlighting feature consists of having markers to guide the user's eye into the details. I'm not convinced by having different highlighting behaviors between "types" as the default behavior since it could create more confusion in the end than being really helpful on a frontend side. On the other hand, we could give the possibility in the future to define the behavior of the highlighting feature e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Thearas @MarinPostma! This PR should fix the issue, thanks! thanks again for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution :)
bors merge
Build succeeded:
|
Pull Request
What does this PR do?
Implement #1883.
I have test this PR with unit test. It appears to be working properly:
PTAL @curquiza
PR checklist
Please check if your PR fulfills the following requirements: