bug(lib): drop env on last use #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
requested changes
Dec 15, 2021
meilisearch-lib/src/snapshot.rs
Outdated
| @@ -90,7 +90,7 @@ pub struct SnapshotJob { | |||
|
|
|||
| impl SnapshotJob { | |||
| pub async fn run(self) -> anyhow::Result<()> { | |||
| tokio::task::spawn_blocking(|| self.run_sync()).await??; | |||
| tokio::task::spawn_blocking(|| dbg!(self.run_sync())).await??; | |||
There was a problem hiding this comment.
Suggested change
| tokio::task::spawn_blocking(|| dbg!(self.run_sync())).await??; | |
| tokio::task::spawn_blocking(|| self.run_sync()).await??; |
| keys: Database<ByteSlice, SerdeJson<Key>>, | ||
| action_keyid_index_expiration: Database<KeyIdActionCodec, SerdeJson<Option<DateTime<Utc>>>>, | ||
| } | ||
|
|
||
| impl Drop for HeedAuthStore { | ||
| fn drop(&mut self) { | ||
| if Arc::strong_count(&self.env) == 1 { |
There was a problem hiding this comment.
I consider it safe to check that the count is equal to 1 as there is no way it can grow between the moment you acquire this number and you compare it to 1.
MarinPostma
force-pushed
the
fix-too-many-open-files
branch
from
b12769b
to
ad2a588
Compare
Kerollmops
requested changes
Dec 16, 2021
My bad I pushed an empty commit --' |
fixes the `too many open files` error when running tests by closing the environment on last drop
MarinPostma
force-pushed
the
fix-too-many-open-files
branch
from
ad2a588
to
b28a465
Compare
Kerollmops
approved these changes
Dec 16, 2021
|
bors merge |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 16, 2021
2011: bug(lib): drop env on last use r=curquiza a=MarinPostma fixes the `too many open files` error when running tests by closing the environment on last drop To check that we are actually the last owner of the `env` we plan to drop, I have wrapped all envs in `Arc`, and check that we have the last reference to it. Co-authored-by: Marin Postma <postma.marin@protonmail.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Dec 16, 2021
2011: bug(lib): drop env on last use r=curquiza a=MarinPostma fixes the `too many open files` error when running tests by closing the environment on last drop To check that we are actually the last owner of the `env` we plan to drop, I have wrapped all envs in `Arc`, and check that we have the last reference to it. Co-authored-by: Marin Postma <postma.marin@protonmail.com>
|
Build failed: |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the
too many open fileserror when running tests by closing theenvironment on last drop
To check that we are actually the last owner of the
envwe plan to drop, I have wrapped all envs inArc, and check that we have the last reference to it.