fix: docker image failed to boot on arm64 node #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thearas
force-pushed
the
fix-image-arm64
branch
3 times, most recently
from
65c9487
to
42cb94e
Compare
curquiza
reviewed
Feb 14, 2022
Thearas
changed the title
Thearas
commented
Feb 14, 2022
Comment on lines
21
to
30
| # Create dummy main.rs files for each workspace member to be able to compile all the dependencies | ||
| RUN find . -type d -name "meilisearch-*" | xargs -I{} sh -c 'mkdir {}/src; echo "fn main() { }" > {}/src/main.rs;' | ||
| # Use `cargo build` instead of `cargo vendor` because we need to not only download but compile dependencies too | ||
| RUN $HOME/.cargo/bin/cargo build --release | ||
| RUN if [ "$TARGETPLATFORM" = "linux/arm64" ]; then \ | ||
| export JEMALLOC_SYS_WITH_LG_PAGE=16; \ | ||
| fi && \ | ||
| $HOME/.cargo/bin/cargo build --release | ||
| # Cleanup dummy main.rs files | ||
| RUN find . -path "*/src/main.rs" -delete | ||
|
|
There was a problem hiding this comment.
Hi @curquiza, I tested it successfully on arm64 machine. But compiling the image is just too slow 😂.
BTW, can we remove the cargo build above? It does not seem necessary.
There was a problem hiding this comment.
Hum, I would rather remove this line in another PR to ensure we do not any mistake by introducing JEMALLOC_SYS_LG_PAGE
Thearas
changed the title
curquiza
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #2115.
PR checklist
Please check if your PR fulfills the following requirements: