Fix max dbs error #2192
Merged
Fix max dbs error #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
fix-max-dbs
branch
3 times, most recently
from
44a21b5
to
cc3ac7d
Compare
Kerollmops
previously approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Thank you @MarinPostma for the changes, it is indeed something that heed must do: keep the environments open in order to make sure that the program doesn't try to open them multiple times.
bors merge
bors bot
added a commit
that referenced
this pull request
Feb 23, 2022
2192: Fix max dbs error r=Kerollmops a=MarinPostma Factor the way we open environments to make sure they are always opened with the same options. The issue was that indexes were first opened in snapshots with incorrect options, and heed cache returned an environment with incorrect open options on subsequent index open. fix #2190 Co-authored-by: ad hoc <postma.marin@protonmail.com>
|
bors cancel |
|
Canceled. |
MarinPostma
force-pushed
the
fix-max-dbs
branch
from
cc3ac7d
to
7e83210
Compare
|
@Kerollmops yep it's done |
Kerollmops
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor the way we open environments to make sure they are always opened with the same options.
The issue was that indexes were first opened in snapshots with incorrect options, and heed cache returned an environment with incorrect open options on subsequent index open.
fix #2190