Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actix-web dependency to 4.0 #2194

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Update actix-web dependency to 4.0 #2194

merged 2 commits into from
Feb 28, 2022

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Feb 25, 2022

Pull Request

What does this PR do?

Updates Actix Web ecosystem crates to 4.0 stable.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

irevoire
irevoire previously approved these changes Feb 26, 2022
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'll let @MarinPostma merge 👍

@irevoire irevoire added this to the v0.27.0 milestone Feb 26, 2022
@MarinPostma MarinPostma changed the base branch from main to release-v0.26.0 February 28, 2022 13:21
@MarinPostma MarinPostma dismissed irevoire’s stale review February 28, 2022 13:21

The base branch was changed.

@MarinPostma MarinPostma changed the base branch from release-v0.26.0 to main February 28, 2022 13:26
@MarinPostma
Copy link
Contributor

Looks good to me @robjtede, can you just run clippy so the CI passes? thanks!

@MarinPostma
Copy link
Contributor

thanks @robjtede !

bors merge

bors bot added a commit that referenced this pull request Feb 28, 2022
2194: update actix-web dependency to 4.0 r=MarinPostma a=robjtede

# Pull Request

## What does this PR do?
Updates Actix Web ecosystem crates to 4.0 stable.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] ~~Does this PR fix an existing issue?~~
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?




Co-authored-by: Rob Ede <robjtede@icloud.com>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

@bors bors bot merged commit 0c9e8cd into meilisearch:main Feb 28, 2022
@curquiza curquiza changed the title update actix-web dependency to 4.0 Update actix-web dependency to 4.0 Feb 28, 2022
@robjtede robjtede deleted the aw4 branch February 28, 2022 23:40
@curquiza curquiza removed this from the v0.27.0 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants