Add test to validate cli #2245
Merged
Add test to validate cli #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
test-valid-cli
branch
2 times, most recently
from
d79dc4c
to
0719e2f
Compare
|
will wait for #2243 to merge before, or the CI will fail. |
curquiza
requested changes
Mar 16, 2022
MarinPostma
force-pushed
the
test-valid-cli
branch
from
0719e2f
to
61ebd6e
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 17, 2022
2245: Add test to validate cli r=MarinPostma a=MarinPostma followup on #2242 and #2243 Add a test to make sure the cli is valid, and add a CI task to run the tests in debug to make sure we hit debug assertions. FYI `@curquiza,` because of CI changes Co-authored-by: ad hoc <postma.marin@protonmail.com>
|
bors cancel |
|
Canceled. |
|
I need to fix the new CI |
MarinPostma
force-pushed
the
test-valid-cli
branch
from
61ebd6e
to
1d68386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #2242 and #2243
Add a test to make sure the cli is valid, and add a CI task to run the tests in debug to make sure we hit debug assertions.
FYI @curquiza, because of CI changes