Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instance options for RAM and CPU usage #2267

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Add instance options for RAM and CPU usage #2267

merged 5 commits into from
Mar 31, 2022

Conversation

yoseio
Copy link
Contributor

@yoseio yoseio commented Mar 24, 2022

Pull Request

What does this PR do?

Fixes #2212

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza added this to the v0.27.0 milestone Mar 29, 2022
@curquiza
Copy link
Member

Hello @2shiori17
thanks a lot for this PR, can you fix the git conflicts before @MarinPostma and @Kerollmops review it? 🙂

Kerollmops
Kerollmops requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR, really appreciate it. Could you change those small things, please?

meilisearch-lib/src/options.rs Outdated Show resolved Hide resolved
meilisearch-lib/src/options.rs Outdated Show resolved Hide resolved
meilisearch-lib/src/options.rs Show resolved Hide resolved
@yoseio
Copy link
Contributor Author

yoseio commented Mar 31, 2022

Thank you for your review. I have fixed it.

Kerollmops
Kerollmops approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work 🎉 🙏
bors merge

@bors
Copy link
Contributor

bors bot commented Mar 31, 2022

Build succeeded:

@bors bors bot merged commit 87e4125 into meilisearch:main Mar 31, 2022
@yoseio yoseio deleted the add-instance-options branch March 31, 2022 16:13
@curquiza curquiza mentioned this pull request Apr 6, 2022
Closed
@curquiza curquiza added the v0.27.0 PRs/issues solved in v0.27.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@MarinPostma MarinPostma Awaiting requested review from MarinPostma

Assignees
No one assigned
Labels
v0.27.0 PRs/issues solved in v0.27.0
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.

New instance options: RAM and CPU usage
3 participants
@yoseio @curquiza @Kerollmops