Simplify Dockerfile #2271
Merged
Simplify Dockerfile #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Mar 28, 2022
There was a problem hiding this comment.
Thanks @Thearas for this PR!!
The build and the image both work on my MacOs (non-m1).
I let @ManyTheFish and @irevoire test and review :)
I tested it on my M1 mac, and it works! |
ManyTheFish
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
$TARGETPLATFORMwithapk --print-archto make Dockerfile available fordocker buildas well, not justdocker buildx(inspired by rust-lang/docker-rust)PTAL @curquiza
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!