Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): fix panic when sending document update without content type header #2277

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

MarinPostma
Copy link
Contributor

I found a panic when pushing documents without a content-type. This fixes is by returning unknown instead of crashing.

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curquiza
Copy link
Member

curquiza commented Mar 29, 2022

Is it something that would deserve v0.26.2?

EDIT: it's a bug only present in main? not in v0.26.1?

@curquiza curquiza added this to the v0.27.0 milestone Mar 29, 2022
@MarinPostma
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 5, 2022

@bors bors bot merged commit 7f7958f into main Apr 5, 2022
@bors bors bot deleted the fix-analytics-panic branch April 5, 2022 12:27
@curquiza curquiza added the v0.27.0 PRs/issues solved in v0.27.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.27.0 PRs/issues solved in v0.27.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants